Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kubernetes to 1.28.x #3138

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Update kubernetes to 1.28.x #3138

merged 2 commits into from
Oct 31, 2023

Conversation

curtbushko
Copy link
Contributor

@curtbushko curtbushko commented Oct 26, 2023 •
edited
Loading

Changes proposed in this PR:

  • Set Kind and GKE to use 1.28.x for acceptance tests
  • Note: GKE needed to be hardcoded as the terraform resource google_container_engine_versions is not returning values for latest_master_version

How I've tested this PR:

  • Ran the Kind and GKE Acceptance tests.

How I expect reviewers to test this PR:

👀

Checklist:

@curtbushko curtbushko force-pushed the curtbushko/upgrade-kube-1.28 branch 2 times, most recently from e0656e3 to 6789bcc Compare October 30, 2023 14:33
@curtbushko curtbushko changed the title Update kind to 1.28.0 Update kubernetes to 1.28.0 Oct 30, 2023
@curtbushko curtbushko changed the title Update kubernetes to 1.28.0 Update kubernetes to 1.28.x Oct 30, 2023
@curtbushko
Update kind to 1.28.0
100219b 
Hardcode GKE version for now and update all clouds from 1.26 -> 1.28
@curtbushko curtbushko force-pushed the curtbushko/upgrade-kube-1.28 branch from a17c90e to 100219b Compare October 30, 2023 19:31
@curtbushko curtbushko self-assigned this Oct 30, 2023
@curtbushko curtbushko added the backport/1.3.x This release branch is no longer active. label Oct 30, 2023
@curtbushko curtbushko requested a review from david-yu October 30, 2023 19:33
@curtbushko curtbushko marked this pull request as ready for review October 30, 2023 19:33
david-yu
david-yu approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@david-yu david-yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update README.md to include the supported versions?

@david-yu
Copy link
Contributor

consul-k8s/README.md

Line 59 in 692c783

* **Kubernetes 1.24.x - 1.27.x** - This represents the earliest versions of Kubernetes tested.

@david-yu
Copy link
Contributor

david-yu commented Oct 30, 2023 •
edited
Loading

We should also bump this version to 1.25.0-0 as well, this seems to have not been bumped up last release.

consul-k8s/charts/consul/Chart.yaml

Line 8 in 7079ad5

kubeVersion: ">=1.22.0-0"

@curtbushko
reset nightly
622daf9 
test 1.25 to 1.28
@curtbushko curtbushko force-pushed the curtbushko/upgrade-kube-1.28 branch from 8c278af to 622daf9 Compare October 31, 2023 13:26
@curtbushko curtbushko added backport/1.3.x This release branch is no longer active. and removed backport/1.3.x This release branch is no longer active. labels Oct 31, 2023
@curtbushko curtbushko merged commit 6024cec into main Oct 31, 2023
6 checks passed
@curtbushko curtbushko deleted the curtbushko/upgrade-kube-1.28 branch October 31, 2023 14:39
@hc-github-team-consul-core hc-github-team-consul-core mentioned this pull request Oct 31, 2023
Merged
2 tasks
curtbushko added a commit that referenced this pull request Oct 31, 2023
@curtbushko
Update kubernetes to 1.28.x (#3138)
9e007d7 
* Update kind to 1.28.0
curtbushko added a commit that referenced this pull request Oct 31, 2023
@curtbushko
Update kubernetes to 1.28.x in release/1.3.0 (#3151)
1b0dfc5 
* Update kubernetes to 1.28.x (#3138)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-yu david-yu david-yu approved these changes

Assignees

@curtbushko curtbushko

Labels
backport/1.3.x This release branch is no longer active.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@curtbushko @david-yu