Fix ArgoCD hooks annotation location

[gcaracuel]

Changes proposed in this PR

ArgoCD hooks to be set to Job annotations and not at Job template spec level -> https://argo-cd.readthedocs.io/en/stable/user-guide/resource_hooks/#usage

If set at current Job template spec level when Job is finished ArgoCD detects back again diff entering into a loop, if ArgoCD AutoSync is enabled this will be a loop of init jobs running forever.

fix: #3831

How I've tested this PR

• Ran helm bats tests successfully.

How I expect reviewers to test this PR

• Deploy this chart using ArgoCD Application. Without the fix after the sync it will enter in a diff sync loop.

Checklist

• Tests added (Not needed)
• CHANGELOG entry added

[hashicorp-cla-app]

All committers have signed the CLA.

[gcaracuel]

Am I missing anything for this to be reviewed?

[ndhanushkodi]

Thanks for fixing this! Waiting for a test run and then I can officially approve. If in the meanwhile you don't mind making these small changes to the changelog that'd be great!