Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump kind and kubectl versions and update k8s support #4244

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

NicoletaPopoviciu
Copy link
Collaborator

@NicoletaPopoviciu NicoletaPopoviciu commented Aug 12, 2024

bump kind and kubectl versions, and update k8s versions tested

Changes proposed in this PR

  • bump kind and kubectl versions
  • update k8s support

How I've tested this PR

How I expect reviewers to test this PR

Checklist

bump kind and kubectl versions, and update k8s versions tested
Copy link
Member

@zalimeni zalimeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more edit we should make, otherwise LGTM!

The acceptance tests that run for this PR should use the updated values automatically, we can observe them being updated here for the latest commit (note the kindest/node image version isn't updated yet): https://github.com/hashicorp/consul-k8s-workflows/actions/runs/10360967522/job/28680500788#step:1:141

acceptance/ci-inputs/kind-inputs.yaml Outdated Show resolved Hide resolved
Co-authored-by: Michael Zalimeni <michael.zalimeni@hashicorp.com>
@NicoletaPopoviciu
Copy link
Collaborator Author

NicoletaPopoviciu commented Aug 13, 2024

@zalimeni thank you ; committed your suggestion.
? re backports - should this only be backported to 1.5.x?

Copy link
Member

@zalimeni zalimeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zalimeni zalimeni enabled auto-merge (squash) August 13, 2024 15:21
@zalimeni
Copy link
Member

zalimeni commented Aug 13, 2024

@zalimeni thank you ; committed your suggestion. ? re backports - should this only be backported to 1.5.x?

Sorry @NicoletaPopoviciu , overlooked this while reviewing. I think yes to this change, then we'll want some targeted changes similar to it, but slightly different, for release/1.4.x and release/1.1.x (docs for those should not say "1.27-1.30" since LTS versions don't typically remove old support, just add new). The Jira ticket has a few notes on those versions, but happy to discuss as well.

@zalimeni zalimeni merged commit ac91932 into main Aug 13, 2024
50 checks passed
@zalimeni zalimeni deleted the nicoleta/NET-10690 branch August 13, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants