-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Case sensitive route match #19647
Case sensitive route match #19647
Conversation
92e4d3b
to
3aed37e
Compare
@david-yu Can you give me a help on this PR? As we have a Consul license + support with my enterprise we tried with our account owner/CSM but no luck. You can find it in my Zendesk ticket 131683. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great so far -- thanks for the contribution. I think the main question here is about whether there's an incompatibility between the new field and regex, but otherwise, I don't see any issues.
test/integration/connect/envoy/case-cfg-router-features/setup.sh
Outdated
Show resolved
Hide resolved
@hashi-derek @jkirschner-hashicorp let me know if I need to change something after my last commits. |
@Lord-Y Hey, sorry for the delay. Yeah, it looks like the CICD is complaining about a missing import during the linting step, which is preventing some tests from running.
|
I don't know this happened as I didn't do anything special. I updated the code with last commits. Let's see how it's going to be. |
@Lord-Y I pushed a commit to your repo to fix the import issue and added in a changelog. All the tests passed, so thank you for the contribution. |
@Lord-Y What version of Consul enterprise are you using? We may need to consider backporting this but would like to check. |
Hi |
This PR needs to be squashed for backporting purposes, and I will have to rebase the commits so that code from main doesn't sneak into 1.17 (due to the several merge commits in the middle of it). I will address this tomorrow, but figured I should point this out in case you see some activity in @Lord-Y 's branch. |
This commit adds in a new feature that allows service routers to specify that paths and path prefixes should ignore upper / lower casing when matching URLs. Co-authored-by: Derek Menteer <105233703+hashi-derek@users.noreply.github.com>
68fe9c4
to
1b458c4
Compare
@Lord-Y It looks like this just missed the cut for 1.17.2 which is coming out this week, this will be delivered as part of 1.17.3. Sorry for the delay here, but I hope this ok timing wise. |
Description
Sometimes we need route to be case insensitive when using
prefix
in order to apply some rules later.Envoy is supporting this feature since a while and can be found here all the way down to version
1.22.x
PR Checklist