Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NET-6317 - update usage of deprecated fields: http2_protocol_options and access_log_path #19940

Merged
merged 4 commits into from
Dec 14, 2023

Conversation

jmurret
Copy link
Member

@jmurret jmurret commented Dec 14, 2023

Description

Remove uses of deprecated fields:

  • envoy.config.cluster.v3.Cluster.http2_protocol_options
  • envoy.config.bootstrap.v3.Admin.access_log_path

Testing & Reproduction steps

CI works

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@jmurret jmurret added backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. backport/1.16 This release series is no longer active on CE. Use backport/ent/1.16. backport/1.17 This release series is no longer active on CE. Use backport/ent/1.17. labels Dec 14, 2023
@jmurret jmurret requested a review from a team as a code owner December 14, 2023 15:02
@github-actions github-actions bot added type/docs Documentation needs to be created/updated/clarified theme/cli Flags and documentation for the CLI interface labels Dec 14, 2023
@jmurret jmurret force-pushed the jm/NET-6317 branch 2 times, most recently from 2939082 to a689681 Compare December 14, 2023 16:04
Copy link
Contributor

@thisisnotashwin thisisnotashwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful!

@jmurret jmurret merged commit a995505 into main Dec 14, 2023
83 checks passed
@jmurret jmurret deleted the jm/NET-6317 branch December 14, 2023 20:08
jmurret added a commit that referenced this pull request Dec 14, 2023
…and access_log_path (#19940)

* updating usage of http2_protocol_options and access_log_path

* add changelog

* update template for AdminAccessLogConfig

* remove mucking with AdminAccessLogConfig
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. backport/1.16 This release series is no longer active on CE. Use backport/ent/1.16. backport/1.17 This release series is no longer active on CE. Use backport/ent/1.17. theme/cli Flags and documentation for the CLI interface type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants