Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NET-6946 / NET-6941 - Replace usage of deprecated Envoy fields envoy.config.route.v3.HeaderMatcher.safe_regex_match and envoy.type.matcher.v3.RegexMatcher.google_re2 #20013

Merged
merged 4 commits into from
Jan 3, 2024

Conversation

jmurret
Copy link
Member

@jmurret jmurret commented Dec 21, 2023

GoogleRe2 was set as the default regex engine and this field deprecated in Envoy 1.23.0. Consul 1.18 will support back to Envoy 1.25. This change will not be backported.

Description

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@jmurret jmurret added backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. backport/1.16 This release series is no longer active on CE. Use backport/ent/1.16. backport/1.17 This release series is no longer active on CE. Use backport/ent/1.17. labels Dec 21, 2023
@github-actions github-actions bot added the theme/envoy/xds Related to Envoy support label Dec 21, 2023
@jmurret jmurret marked this pull request as ready for review December 21, 2023 02:29
@jmurret jmurret requested a review from a team as a code owner December 21, 2023 02:29
@rboyer
Copy link
Member

rboyer commented Dec 21, 2023

Is the new replaced xDS structures being used equally supported on the 4 versions currently configured in consul?

@jmurret jmurret force-pushed the jm/NET-6946 branch 3 times, most recently from 388ac7f to 21cef56 Compare December 22, 2023 16:50
@jmurret jmurret changed the title NET-6946 - Replace usage of deprecated Envoy field envoy.config.route.v3.HeaderMatcher.safe_regex_match NET-6946 / NET-6941 - Replace usage of deprecated Envoy fields envoy.config.route.v3.HeaderMatcher.safe_regex_match and envoy.type.matcher.v3.RegexMatcher.google_re2 Jan 2, 2024
@jmurret jmurret added pr/no-backport and removed backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. backport/1.16 This release series is no longer active on CE. Use backport/ent/1.16. backport/1.17 This release series is no longer active on CE. Use backport/ent/1.17. labels Jan 3, 2024
Copy link
Contributor

@thisisnotashwin thisisnotashwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@jmurret jmurret merged commit d925e4b into main Jan 3, 2024
97 checks passed
@jmurret jmurret deleted the jm/NET-6946 branch January 3, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-backport theme/envoy/xds Related to Envoy support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants