Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default intention policy #20544

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Conversation

kisunji
Copy link
Contributor

@kisunji kisunji commented Feb 8, 2024

Recommended to review commit-by-commit

Description

Adds a new agent configuration field DefaultIntentionPolicy (default_intention_policy) which controls how service-to-service traffic is authorized in the absence of specific intentions.

DefaultIntentionPolicy can be "allow", "deny", or "", where if left blank it will inherit the default ACL policy.

This field will de-couple the ACL subsystem from intentions, allowing users to incrementally adopt secure configurations one step at a time without dealing with implicit dependencies between the two subsystems.

Testing & Reproduction steps

  • Added unit tests which inject default intention policy and observe that it overrides the default ACL policy

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@kisunji kisunji requested a review from a team as a code owner February 8, 2024 19:12
@github-actions github-actions bot added theme/acls ACL and token generation theme/config Relating to Consul Agent configuration, including reloading labels Feb 8, 2024
@kisunji kisunji enabled auto-merge (squash) February 8, 2024 19:15
@kisunji kisunji requested review from a team, johnlanda and roncodingenthusiast and removed request for a team February 8, 2024 19:15
@kisunji kisunji merged commit 26661a1 into main Feb 8, 2024
90 checks passed
@kisunji kisunji deleted the kisunji/default-intention-policy-backport branch February 8, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/acls ACL and token generation theme/config Relating to Consul Agent configuration, including reloading
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants