NET-7813 - DNS : SERVFAIL when resolving PTR records #20679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmurret
added
the
backport/1.17
zalimeni
approved these changes
Feb 20, 2024
DanStough
approved these changes
Feb 21, 2024
Comment on lines
+440
to
+476
| func TestDNS_ReverseLookup_NotFound(t *testing.T) { | ||
| if testing.Short() { | ||
| t.Skip("too slow for testing.Short") | ||
| } | ||
|
|
||
| for name, experimentsHCL := range getVersionHCL(true) { | ||
| t.Run(name, func(t *testing.T) { | ||
| // do not configure recursors | ||
| a := NewTestAgent(t, experimentsHCL) | ||
| defer a.Shutdown() | ||
| testrpc.WaitForLeader(t, a.RPC, "dc1") | ||
|
|
||
| // Do not register any nodes | ||
| m := new(dns.Msg) | ||
| qName := "2.0.0.127.in-addr.arpa." | ||
| m.SetQuestion(qName, dns.TypeANY) | ||
|
|
||
| c := new(dns.Client) | ||
| in, _, err := c.Exchange(m, a.DNSAddr()) | ||
| require.NoError(t, err) | ||
| require.Nil(t, in.Answer) | ||
| require.Nil(t, in.Extra) | ||
|
|
||
| require.Equal(t, dns.RcodeNameError, in.Rcode) | ||
|
|
||
| question := in.Question[0] | ||
| require.Equal(t, qName, question.Name) | ||
| require.Equal(t, dns.TypeANY, question.Qtype) | ||
| require.Equal(t, uint16(dns.ClassINET), question.Qclass) | ||
|
|
||
| soa, ok := in.Ns[0].(*dns.SOA) | ||
| require.True(t, ok) | ||
| require.Equal(t, "ns.consul.", soa.Ns) | ||
| require.Equal(t, "hostmaster.consul.", soa.Mbox) | ||
| }) | ||
| } | ||
| } |
Co-authored-by: Michael Zalimeni <michael.zalimeni@hashicorp.com>
4 tasks
4 tasks
4 tasks
jmurret
added a commit
that referenced
this pull request
Feb 21, 2024
* NET-7813 - DNS : SERVFAIL when resolving PTR records * Update agent/dns.go Co-authored-by: Michael Zalimeni <michael.zalimeni@hashicorp.com> * PR feedback --------- Co-authored-by: Michael Zalimeni <michael.zalimeni@hashicorp.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For PTR records, the recursors enabled flag is not obeyed. It will return a SERVFAIL record in this case.
The acceptance criteria is:
NOTE: Some reverse lookup tests were moved from
dns_test.goanddns_service_lookup_test.gointo the newdns_reverse_lookup_test.gofile so that we did not have to add the newTestDNS_ReverseLookup_NotFound()test intodns_test.goas it it already huge and has issues displaying in Github's UITesting & Reproduction steps
without recursors:
consul agent -devdig -p 8600 -x 127.0.0.3 @localhostExpected Result:
with recursors array defined but without recursors enabled:
consul agent -dev -log-level=debug -hcl 'recursors = ["1.1.1.1"]'Expected Result:
Links
PR Checklist