Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CE] feat(v2dns): enable v2 dns as default #20715

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

DanStough
Copy link
Contributor

Description

This PR default enables the V2 DNS server implementation for Consul 1.19. The experiment flag is changed to v1dns to be able to revert to the old implementation until there is more feedback on V2.

Notes:

  1. I noticed that RB added a gate to prevent these flags on secondary servers, but we definitely should allow this.
  2. This is only for 1.19. I will create a separate PR against 1.18 to re-enable secondary servers using V2 DNS

Testing & Reproduction steps

  • Existing agent tests are updated to run against both implementations.
  • Any integration tests should now run against the new implementation.

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@DanStough DanStough requested a review from jmurret February 23, 2024 16:48
@DanStough DanStough requested a review from a team as a code owner February 23, 2024 16:48
@github-actions github-actions bot added the theme/config Relating to Consul Agent configuration, including reloading label Feb 23, 2024
@DanStough DanStough changed the title feat(v2dns): enable v2 dns as default [CE] feat(v2dns): enable v2 dns as default Feb 23, 2024
@DanStough DanStough force-pushed the dans/NET-8054/v2dns-by-default branch from 6501f5d to 70c2c00 Compare March 25, 2024 18:41
@@ -0,0 +1,6 @@
```release-note:feature
dns: queries now default to a refactored DNS server that is v1 and v2 Catalog compatible.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do multi-line changelog entries do the right thing? I don't think I've authored one before.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should wrap like normal markdown, which I think is OK here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also confirmed looking at 20812.txt - it should up as a single line 👍

@DanStough DanStough merged commit 6026ada into main Mar 25, 2024
97 checks passed
@DanStough DanStough deleted the dans/NET-8054/v2dns-by-default branch March 25, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-backport theme/config Relating to Consul Agent configuration, including reloading
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants