Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dataplane): allow token and tenancy information for proxied DNS #20899

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

DanStough
Copy link
Contributor

Description

This is the Consul component of hashicorp/consul-dataplane#172

By passing along the tenant of the service being proxied we can more intelligently select the correct partition/namespace to use as defaults for DNS.

This also passes along the Consul ACL token as the x-consul-token grpc metadata. Eventually Consul should be able to use this token instead of the servers default token for authorizing access.

This PR also includes a small bit of cleanup as noted in the comments.

Testing & Reproduction steps

  • Unit tests are updated

Links

Dataplane PR

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@DanStough DanStough force-pushed the dans/NET-7885/grpc-dns-context-over-metadata branch from 9dfa97c to f533339 Compare April 19, 2024 15:39
@DanStough DanStough merged commit 03ab736 into main Apr 22, 2024
85 checks passed
@DanStough DanStough deleted the dans/NET-7885/grpc-dns-context-over-metadata branch April 22, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants