Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update retryable-http-client to resolve CVE-2024-6104 #21384

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Update retryable-http-client to resolve CVE-2024-6104 #21384

merged 2 commits into from
Jul 2, 2024

Conversation

sarahalsmiller
Copy link
Member

Description

Update retryable http client to resolve CVE-2024-6104

Testing & Reproduction steps

No behavior changes, CI should pass

Links

https://nvd.nist.gov/vuln/detail/CVE-2024-6104

PR Checklist

  • updated test coverage
  • external facing docs updated
  • [X ] appropriate backport labels added
  • [X ] not a security concern

@sarahalsmiller sarahalsmiller added the backport/all Apply backports for all active releases per .release/versions.hcl label Jul 1, 2024
@github-actions github-actions bot added the pr/dependencies PR specifically updates dependencies of project label Jul 1, 2024
@sarahalsmiller sarahalsmiller marked this pull request as ready for review July 1, 2024 16:03
dduzgun-security
dduzgun-security approved these changes Jul 1, 2024
View reviewed changes
Copy link
Collaborator

@dduzgun-security dduzgun-security left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, LGTM! 👍

@sarahalsmiller sarahalsmiller merged commit 6f31bfe into main Jul 2, 2024
82 checks passed
@sarahalsmiller sarahalsmiller deleted the NET-10256-Vulnerabilities-in-consul-enterprise-go-retryablehttp-can-leak-basic-auth-credentials-to-log-files-in-go.mod-1 branch July 2, 2024 15:12
@hc-github-team-consul-core hc-github-team-consul-core added backport/1.19 This release series is longer active on CE, use backport/ent/1.19 backport/ent/1.17 This release series is longer active on CE or Ent backport/ent/1.15 Changes are backported to 1.15 ent backport/ent/1.18 Changes are backported to 1.18 ent labels Jul 2, 2024
@hc-github-team-consul-core hc-github-team-consul-core mentioned this pull request Jul 2, 2024
Merged
2 tasks
@dduzgun-security
Copy link
Collaborator

Resolves https://github.com/hashicorp/consul-enterprise/security/code-scanning/1022

jmurret pushed a commit that referenced this pull request Jul 8, 2024
@sarahalsmiller @jmurret
Update retryable-http-client to resolve CVE-2024-6104 (#21384)
6e1d719 
* update retryable-http-client

* changelog
@adamcstephens adamcstephens mentioned this pull request Jul 19, 2024
Merged
13 tasks
@dhiaayachi dhiaayachi mentioned this pull request Sep 25, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dduzgun-security dduzgun-security dduzgun-security approved these changes

Assignees
No one assigned
Labels
backport/all Apply backports for all active releases per .release/versions.hcl backport/ent/1.15 Changes are backported to 1.15 ent backport/ent/1.17 This release series is longer active on CE or Ent backport/ent/1.18 Changes are backported to 1.18 ent backport/1.19 This release series is longer active on CE, use backport/ent/1.19 pr/dependencies PR specifically updates dependencies of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sarahalsmiller @dduzgun-security @hc-github-team-consul-core