Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui] Simple url sanitization for get-env and document.cookie #21711

Merged
merged 1 commit into from
Sep 12, 2024
Merged

[ui] Simple url sanitization for get-env and document.cookie #21711

merged 1 commit into from
Sep 12, 2024

Conversation

philrenaud
Copy link
Collaborator

@philrenaud philrenaud added backport/ent/1.17 This release series is longer active on CE or Ent backport/ent/1.15 Changes are backported to 1.15 ent backport/1.19 This release series is longer active on CE, use backport/ent/1.19 backport/ent/1.18 Changes are backported to 1.18 ent labels Sep 11, 2024
@philrenaud philrenaud self-assigned this Sep 11, 2024
@github-actions github-actions bot added the theme/ui Anything related to the UI label Sep 11, 2024
@philrenaud philrenaud force-pushed the SECVULN-6915-consul-enterprise-Client-side-cross-site-scripting-in-ui-packages-consul-ui-app-utils-get-environment.js-62 branch from abe237f to 549d41b Compare September 11, 2024 20:06
@philrenaud philrenaud added backport/all Apply backports for all active releases per .release/versions.hcl and removed backport/ent/1.17 This release series is longer active on CE or Ent backport/ent/1.15 Changes are backported to 1.15 ent backport/1.19 This release series is longer active on CE, use backport/ent/1.19 backport/ent/1.18 Changes are backported to 1.18 ent labels Sep 11, 2024
@philrenaud philrenaud force-pushed the SECVULN-6915-consul-enterprise-Client-side-cross-site-scripting-in-ui-packages-consul-ui-app-utils-get-environment.js-62 branch from 549d41b to 7e2102a Compare September 11, 2024 20:22
@philrenaud philrenaud force-pushed the SECVULN-6915-consul-enterprise-Client-side-cross-site-scripting-in-ui-packages-consul-ui-app-utils-get-environment.js-62 branch from 7e2102a to 9fb851d Compare September 12, 2024 13:37
dduzgun-security
dduzgun-security approved these changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@dduzgun-security dduzgun-security left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM 👍

@philrenaud philrenaud merged commit 0cc0fa7 into main Sep 12, 2024
72 checks passed
@philrenaud philrenaud deleted the SECVULN-6915-consul-enterprise-Client-side-cross-site-scripting-in-ui-packages-consul-ui-app-utils-get-environment.js-62 branch September 12, 2024 16:27
@hc-github-team-consul-core hc-github-team-consul-core added backport/1.19 This release series is longer active on CE, use backport/ent/1.19 backport/ent/1.17 This release series is longer active on CE or Ent backport/ent/1.15 Changes are backported to 1.15 ent backport/ent/1.18 Changes are backported to 1.18 ent labels Sep 12, 2024
@hc-github-team-consul-core hc-github-team-consul-core mentioned this pull request Sep 12, 2024
Merged
philrenaud added a commit that referenced this pull request Sep 12, 2024
@philrenaud
[ui] Simple url sanitization for get-env and document.cookie (#21711)
aa8d1bc 
Simple url sanitization for get-env and document.cookie
@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @philrenaud! a backport is missing for this PR [21711] for versions [1.15,1.17,1.18,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@dhiaayachi dhiaayachi mentioned this pull request Sep 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dduzgun-security dduzgun-security dduzgun-security approved these changes

@sarahalsmiller sarahalsmiller Awaiting requested review from sarahalsmiller

Assignees

@philrenaud philrenaud

Labels
backport/all Apply backports for all active releases per .release/versions.hcl backport/ent/1.15 Changes are backported to 1.15 ent backport/ent/1.17 This release series is longer active on CE or Ent backport/ent/1.18 Changes are backported to 1.18 ent backport/1.19 This release series is longer active on CE, use backport/ent/1.19 theme/ui Anything related to the UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philrenaud @hc-github-team-consul-core @dduzgun-security