Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed typo in error message, removed unused check #241

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed typo in error message, removed unused check #241

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions authentication/environment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ func AzureEnvironmentByNameFromEndpoint(ctx context.Context, endpoint string, en
}

if endpoint == "" {
return nil, fmt.Errorf("unable to locate metadata for environment %q from the built in `public`, `usgoverment`, `china` and no custom metadata host has been specified", environmentName)
return nil, fmt.Errorf("unable to locate metadata for environment %q from the built in `public`, `usgovernment`, `china` and no custom metadata host has been specified", environmentName)
}

environments, err := getSupportedEnvironments(ctx, endpoint)
Expand Down Expand Up @@ -147,9 +147,6 @@ func IsEnvironmentAzureStack(ctx context.Context, endpoint string, environmentNa

// while the array contains values
for _, env := range environments {
if err != nil {
return false, fmt.Errorf("unable to decode environment from %q response: %+v", endpoint, err)
}
if strings.EqualFold(env.Name, environmentName) {
if !strings.EqualFold(env.Authentication.IdentityProvider, "AAD") || !strings.EqualFold(env.Authentication.Tenant, "common") {
return true, nil
Expand Down