Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is The Diff of v2 to v1 #461

Open
gastraight opened this issue Oct 20, 2023 · 1 comment
Open

What is The Diff of v2 to v1 #461

gastraight opened this issue Oct 20, 2023 · 1 comment

Comments

@gastraight
Copy link

Hi!
Please. What is the principal difference for v2 against v1 (in terms of public api)
Is extracting a Request from a Client entity the main (only) change?
What critical points should be considered for migration steps?
Except for cmd/main maybe is there any other examples to disclose the diff?

Thanks

@gastraight
Copy link
Author

gastraight commented Oct 21, 2023

And would for v1 getter.Detect() in v2 be an equivalent to iterate over client getters?

for _, getter := range client.Getters {
    ok, err := getter.Detect(req)
    if ok || err != nil {
       return  req.Src, ok, err
    }
}
 return  req.Src, false, nil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant