Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorect handling of slashes in git refs #469

Open
denis256 opened this issue Jan 22, 2024 · 0 comments
Open

Incorect handling of slashes in git refs #469

denis256 opened this issue Jan 22, 2024 · 0 comments

Comments

@denis256
Copy link

Noticed that go-getter handles incorrectly git paths which have slashes in ref parameter

Example:

# go-getter 1.7.3
$ go-getter "github.com/denis256/terraform-test-module.git//modules/test-file?ref=master" /tmp/test/ 
2024/01/22 17:16:09 success!

$ go-getter "github.com/denis256/terraform-test-module.git//modules/test-file?ref=team/ABC-1234-component" /tmp/test/ 
2024/01/22 17:18:19 Error downloading: error downloading 'https://github.com/denis256/terraform-test-module.git?ref=team': /usr/bin/git exited with 1: error: pathspec 'team' did not match any file(s) known to git

Looks like it is attempted to get https://github.com/denis256/terraform-test-module.git?ref=team instead of ref=team/ABC-1234-component

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant