-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[for go-getter v1] use %w
instead of %s
to wrap error
#474
Comments
%w
instead of %s
to wrap error%w
instead of %s
to wrap error
Hi, @jbardin I'm not sure if you are the maintainer of this repository. If you had time, may you discuss this issue with core team and make a decision? |
Thanks for this submission. We reviewed it today in triage. Although this is the correct action for modernizing error handing in This is just to set expectations with regards to this pull request. I am happy to leave it open in case we decide to merge the functionality in the future. One thing to note, it seems you have committed the files with spaces changed to tabs, which creates a relatively noisy diff. If you intend to leave this PR open, you may want to correct that to make a future review easier to complete. Thanks again for your interest and your submission! |
@crw Thank you for your reply. I'd be happy to keep it open. Some noisy change were probably due to Now, I have fixed it. |
Hi all,
I am still working with go-getter v1.7.3.
I found that in this version,
%s
is used instead of%w
when wrapping errors viafmt.Errorf
.As a result, callers of go-getter will not be able to handle errors gracefully through methods such as
errors.As
orerrors.Unwrap
.If you think the above needs to be changed, I will take my effort to make a PR to fix this. 😃😃
The text was updated successfully, but these errors were encountered: