Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to be able to attach a debugger to subprocesses. #100

Open
joshuarowe-salesforce opened this issue Feb 25, 2019 · 1 comment
Open

Comments

@joshuarowe-salesforce
Copy link

joshuarowe-salesforce commented Feb 25, 2019

See #20466 in terraform.

I'm working on some changes to rpc_client.go and client.go to implement this.

@joshuarowe-salesforce
Copy link
Author

I'm proposing adding a *NetRpcConfig member to the ClientConfig struct that looks like:

// NetRpcConfig allows providing properties of an underlying connection
// via the ClientConfig.NetRpcConfig field.
type NetRpcConfig struct {
	// EnableKeepalive is used to do a period keep alive
	// messages using a ping.
	EnableKeepAlive bool

	// KeepAliveInterval is how often to perform the keep alive
	KeepAliveInterval time.Duration

	// ConnectionWriteTimeout is meant to be a "safety valve" timeout after
	// we which will suspect a problem with the underlying connection and
	// close it. This is only applied to writes, where's there's generally
	// an expectation that things will move along quickly.
	ConnectionWriteTimeout time.Duration
}

Then I'll have the rpc_client.go pay attention to this structure to create a yamux.Config struct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant