-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add gpu uuid
to the fingerprinted attributes
#11
Comments
Hi @shumin1027 👋 I believe the UUID is just missing from the documentation as the fingerprinter does report the UUID. Could you check if the GPU UUID is present when you run |
@lgfa29 nomad-device-nvidia/fingerprint.go Lines 13 to 24 in 541c8ca
And here's how to populate the attribute data, it can be seen that there is indeed no nomad-device-nvidia/fingerprint.go Line 167 in 541c8ca
nomad-device-nvidia/fingerprint.go Line 181 in 541c8ca
|
@lgfa29 nomad-device-nvidia/fingerprint.go Line 181 in 541c8ca
But a new problem was found: nomad-device-nvidia/fingerprint.go Lines 164 to 167 in 541c8ca
Two GPUs with different UUIDs will be treated as one device with the same fingerprinted attributes I still don't know how to solve this problem elegantly |
Oh, you're right @shumin1027, I misunderstood the code. I don't think it's possible to fix this at the plugin level, it seems like a limitation within Nomad. I opened hashicorp/nomad#15455 to try and fix this. I'm building custom binaries for you to test if you have the chance and I will post them here once they're ready. |
Here are the custom binaries: https://github.com/hashicorp/nomad/actions/runs/3604896100#artifacts |
@lgfa29 It's great, I will continue to test |
Nice! If the fix for you feel free to close this issue. The expect the PR to be merged soon and for it to be released in the next version of Nomad. |
Hello @shumin1027, @lgfa29 ! Thank you! |
Hi @ruspaul013 👋 I answered in your post, but TL;DR: yes, you need to upgrade your Nomad clients to a version that includes this change. |
Hello @lgfa29 👋 |
I want to use
gpu uuid
when configuringaffinity
orconstraint
,but there is no such attribute in fingerprinted attributes,how should it be achieved?Fingerprinted Attributes
The text was updated successfully, but these errors were encountered: