Skip to content
This repository has been archived by the owner on Nov 20, 2023. It is now read-only.

enhancement: Support new QueryOpts & Evaluations filter settings #81

Open
5 tasks
DerekStrickland opened this issue Dec 9, 2021 · 2 comments
Open
5 tasks
Labels
enhancement New feature or request

Comments

@DerekStrickland
Copy link
Contributor

Once this PR lands, Evaluations will be the first API to support pagination and filtering options.

We'll need to:

  • Update the QueryOpts struct to support LastToken and deprecate NextToken.
  • Update the setQueryOpts framework method and associated tests to manage the new parameter and warn on use of the deprecated parameter (possibly a new X-Deprecation-Warning header or something similar - need to design)
  • Update the Evaluations generator code to include new supported query parameters
  • Update the set of default query options in the generator code
  • Regenerate clients
@DerekStrickland DerekStrickland added the enhancement New feature or request label Dec 9, 2021
@tgross
Copy link
Member

tgross commented Dec 9, 2021

@DerekStrickland in lieu of future work to automate this all, let's update the contributing guide checklist to make sure changes to the API get followed-up here as well.

@DerekStrickland
Copy link
Contributor Author

Done

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants