From 212fed63dfa209e133fe234816d09f49d33e9503 Mon Sep 17 00:00:00 2001
From: Alex Dadgar <alex.dadgar@gmail.com>
Date: Sun, 30 Jul 2017 17:51:38 -0700
Subject: [PATCH] Fix leaked plugin files for syslog server

This PR fixes a leaking of the unix socket used when launching a syslog
server for the Docker driver.

Fixes https://github.com/hashicorp/nomad/issues/2844
---
 client/driver/logging/syslog_server.go | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/client/driver/logging/syslog_server.go b/client/driver/logging/syslog_server.go
index f059ef77b3de..5b9c5f40f88e 100644
--- a/client/driver/logging/syslog_server.go
+++ b/client/driver/logging/syslog_server.go
@@ -37,11 +37,17 @@ func (s *SyslogServer) Start() {
 	for {
 		select {
 		case <-s.doneCh:
-			s.listener.Close()
 			return
 		default:
 			connection, err := s.listener.Accept()
 			if err != nil {
+				s.doneLock.Lock()
+				done := s.done
+				s.doneLock.Unlock()
+				if done {
+					return
+				}
+
 				s.logger.Printf("[ERR] logcollector.server: error in accepting connection: %v", err)
 				continue
 			}
@@ -74,11 +80,12 @@ func (s *SyslogServer) read(connection net.Conn) {
 // Shutdown shutsdown the syslog server
 func (s *SyslogServer) Shutdown() {
 	s.doneLock.Lock()
-	s.doneLock.Unlock()
+	defer s.doneLock.Unlock()
 
 	if !s.done {
 		close(s.doneCh)
 		close(s.messages)
 		s.done = true
+		s.listener.Close()
 	}
 }