diff --git a/nomad/blocked_evals.go b/nomad/blocked_evals.go index 3a49c964276d..52ee829f1159 100644 --- a/nomad/blocked_evals.go +++ b/nomad/blocked_evals.go @@ -106,6 +106,7 @@ func (b *BlockedEvals) SetEnabled(enabled bool) { b.l.Lock() if b.enabled == enabled { // No-op + b.l.Unlock() return } else if enabled { go b.watchCapacity() diff --git a/nomad/periodic.go b/nomad/periodic.go index 97e1b24523f0..09dadfdff35a 100644 --- a/nomad/periodic.go +++ b/nomad/periodic.go @@ -81,7 +81,11 @@ func (s *Server) DispatchJob(job *structs.Job) (*structs.Evaluation, error) { // RunningChildren checks whether the passed job has any running children. func (s *Server) RunningChildren(job *structs.Job) (bool, error) { - state := s.fsm.State() + state, err := s.fsm.State().Snapshot() + if err != nil { + return false, err + } + prefix := fmt.Sprintf("%s%s", job.ID, structs.PeriodicLaunchSuffix) iter, err := state.JobsByIDPrefix(prefix) if err != nil { @@ -272,11 +276,13 @@ func (p *PeriodicDispatch) ForceRun(jobID string) (*structs.Evaluation, error) { // Do nothing if not enabled if !p.enabled { + p.l.Unlock() return nil, fmt.Errorf("periodic dispatch disabled") } job, tracked := p.tracked[jobID] if !tracked { + p.l.Unlock() return nil, fmt.Errorf("can't force run non-tracked job %v", jobID) }