From 80a04052b6c4f10bae00a147b460b519de7d9a9e Mon Sep 17 00:00:00 2001 From: Nick Ethier Date: Thu, 24 Jan 2019 23:57:07 -0500 Subject: [PATCH] scheduler: fix NPE when deployment is nil, but placement is a canary --- scheduler/generic_sched.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scheduler/generic_sched.go b/scheduler/generic_sched.go index e4b27b64e9e4..03b35b943ae5 100644 --- a/scheduler/generic_sched.go +++ b/scheduler/generic_sched.go @@ -517,7 +517,7 @@ func (s *GenericScheduler) computePlacements(destructive, place []placementResul // If we are placing a canary and we found a match, add the canary // to the deployment state object and mark it as a canary. - if missing.Canary() { + if missing.Canary() && s.deployment != nil { if state, ok := s.deployment.TaskGroups[tg.Name]; ok { state.PlacedCanaries = append(state.PlacedCanaries, alloc.ID) }