From 70c10831e1046be1a90c564b6ea42b7034e4205e Mon Sep 17 00:00:00 2001
From: Tim Gross <tgross@hashicorp.com>
Date: Tue, 1 Mar 2022 08:10:43 -0500
Subject: [PATCH] address comments from code review

---
 .changelog/12129.txt |  3 ++
 volume-0.json        | 58 ------------------------------------
 volume.json          | 71 --------------------------------------------
 3 files changed, 3 insertions(+), 129 deletions(-)
 create mode 100644 .changelog/12129.txt
 delete mode 100644 volume-0.json
 delete mode 100644 volume.json

diff --git a/.changelog/12129.txt b/.changelog/12129.txt
new file mode 100644
index 000000000000..246899e83433
--- /dev/null
+++ b/.changelog/12129.txt
@@ -0,0 +1,3 @@
+```release-note:improvement
+csi: Added support for storage topology
+```
diff --git a/volume-0.json b/volume-0.json
deleted file mode 100644
index 8cf5d1a6b571..000000000000
--- a/volume-0.json
+++ /dev/null
@@ -1,58 +0,0 @@
-{
-  "id": "ebs_prod_db1",
-  "name": "database",
-  "type": "csi",
-  "plugin_id": "plugin_id",
-  "external_id": "vol-23452345",
-  "snapshot_id": "snap-12345",
-  "capacity_min": "10GiB",
-  "capacity_max": "20G",
-  "capability": [
-    {
-      "access_mode": "single-node-writer",
-      "attachment_mode": "file-system"
-    },
-    {
-      "access_mode": "single-node-reader",
-      "attachment_mode": "block-device"
-    }
-  ],
-  "context": [
-    {
-      "endpoint": "http://192.168.1.101:9425"
-    }
-  ],
-  "mount_options": [
-    {
-      "fs_type": "ext4",
-      "mount_flags": [
-        "ro"
-      ]
-    }
-  ],
-  "topology_request": {
-    "preferred": [
-      "topology": {
-        "segments": {"rack": "R1"}
-      }
-    ],
-    "required": [
-      "topology": {
-        "segments": {"rack": "R1"}
-      },
-      "topology": {
-        "segments": {"rack": "R2", "zone": "us-east-1a" }
-      }
-    ]
-  },
-  "parameters": [
-    {
-      "skuname": "Premium_LRS"
-    }
-  ],
-  "secrets": [
-    {
-      "example_secret": "xyzzy"
-    }
-  ]
-}
\ No newline at end of file
diff --git a/volume.json b/volume.json
deleted file mode 100644
index a517f1b23222..000000000000
--- a/volume.json
+++ /dev/null
@@ -1,71 +0,0 @@
-{
-  "id": "ebs_prod_db1",
-  "name": "database",
-  "type": "csi",
-  "plugin_id": "plugin_id",
-  "external_id": "vol-23452345",
-  "snapshot_id": "snap-12345",
-  "capacity_min": "10GiB",
-  "capacity_max": "20G",
-  "capability": [
-    {
-      "access_mode": "single-node-writer",
-      "attachment_mode": "file-system"
-    },
-    {
-      "access_mode": "single-node-reader",
-      "attachment_mode": "block-device"
-    }
-  ],
-  "context": [
-    {
-      "endpoint": "http://192.168.1.101:9425"
-    }
-  ],
-  "mount_options": [
-    {
-      "fs_type": "ext4",
-      "mount_flags": [
-        "ro"
-      ]
-    }
-  ],
-  "topology_request": {
-    "preferred": [
-      {
-        "topology": {
-          "segments": {
-            "rack": "R1"
-          }
-        }
-      }
-    ],
-    "required": [
-      {
-        "topology": {
-          "segments": {
-            "rack": "R1"
-          }
-        }
-      },
-      {
-        "topology": {
-          "segments": {
-            "rack": "R2",
-            "zone": "us-east-1a"
-          }
-        }
-      }
-    ]
-  },
-  "parameters": [
-    {
-      "skuname": "Premium_LRS"
-    }
-  ],
-  "secrets": [
-    {
-      "example_secret": "xyzzy"
-    }
-  ]
-}