From 7f8abfdeac594277253931817a212ab2c6e9d467 Mon Sep 17 00:00:00 2001 From: Phil Renaud Date: Mon, 11 Jul 2022 12:29:27 -0400 Subject: [PATCH] Side effect: ensure at least one test recommendation is of MemoryMB resource type --- ui/tests/acceptance/optimize-test.js | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/ui/tests/acceptance/optimize-test.js b/ui/tests/acceptance/optimize-test.js index 3e8c63f683bf..2d308addf9ab 100644 --- a/ui/tests/acceptance/optimize-test.js +++ b/ui/tests/acceptance/optimize-test.js @@ -76,6 +76,12 @@ module('Acceptance | optimize', function (hooks) { .flat() .find((r) => r.resource === 'CPU'); + const currentTaskGroupHasMemoryRecommendation = + currentTaskGroup.tasks.models + .mapBy('recommendations.models') + .flat() + .find((r) => r.resource === 'MemoryMB'); + // If no CPU recommendation, will not be able to accept recommendation with all memory recommendations turned off if (!currentTaskGroupHasCPURecommendation) { @@ -85,6 +91,13 @@ module('Acceptance | optimize', function (hooks) { resource: 'CPU', }); } + if (!currentTaskGroupHasMemoryRecommendation) { + const currentTaskGroupTask = currentTaskGroup.tasks.models[0]; + this.server.create('recommendation', { + task: currentTaskGroupTask, + resource: 'MemoryMB', + }); + } await Optimize.visit();