From 7fe49c00fcc6e7a7f4e1eeb3f30506176194d35c Mon Sep 17 00:00:00 2001
From: Luiz Aoqui <luiz@hashicorp.com>
Date: Mon, 9 Aug 2021 17:49:08 -0400
Subject: [PATCH] ui: only dipslay "Dispatch Job" button on parameterized jobs
 (#11019)

---
 .changelog/11019.txt                          |  3 ++
 .../components/job-page/parts/children.hbs    | 34 ++++++++++---------
 2 files changed, 21 insertions(+), 16 deletions(-)
 create mode 100644 .changelog/11019.txt

diff --git a/.changelog/11019.txt b/.changelog/11019.txt
new file mode 100644
index 000000000000..089b8a3f025c
--- /dev/null
+++ b/.changelog/11019.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+ui: Fixed a bug where the "Dispatch Job" button was displayed for non-parameterized jobs
+```
diff --git a/ui/app/templates/components/job-page/parts/children.hbs b/ui/app/templates/components/job-page/parts/children.hbs
index 681c28c17c44..e9d81d3be48e 100644
--- a/ui/app/templates/components/job-page/parts/children.hbs
+++ b/ui/app/templates/components/job-page/parts/children.hbs
@@ -1,21 +1,23 @@
 <div class="boxed-section-head">
   Job Launches
-  {{#if (can "dispatch job" namespace=this.job.namespace)}}
-    <LinkTo
-      data-test-dispatch-button
-      @route="jobs.job.dispatch"
-      class="button is-primary is-compact pull-right">
-      Dispatch Job
-    </LinkTo>
-  {{else}}
-    <button
-      data-test-dispatch-button
-      class="button is-disabled is-primary is-compact pull-right tooltip multiline"
-      aria-label="You don’t have permission to dispatch jobs"
-      disabled
-      type="button">
-      Dispatch Job
-    </button>
+  {{#if this.job.parameterized}}
+    {{#if (can "dispatch job" namespace=this.job.namespace)}}
+      <LinkTo
+        data-test-dispatch-button
+        @route="jobs.job.dispatch"
+        class="button is-primary is-compact pull-right">
+        Dispatch Job
+      </LinkTo>
+    {{else}}
+      <button
+        data-test-dispatch-button
+        class="button is-disabled is-primary is-compact pull-right tooltip multiline"
+        aria-label="You don’t have permission to dispatch jobs"
+        disabled
+        type="button">
+        Dispatch Job
+      </button>
+    {{/if}}
   {{/if}}
 </div>
 <div class="boxed-section-body {{if this.sortedChildren.length "is-full-bleed"}}">