From ce5b47443573dde7074aa8475afe7f6c313ac492 Mon Sep 17 00:00:00 2001 From: Michael Schurter Date: Tue, 14 May 2019 09:10:09 -0700 Subject: [PATCH] docs: changelog entry for #5669 and fix comment --- CHANGELOG.md | 7 +++++++ client/allocrunner/taskrunner/task_runner.go | 3 +-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6e793909e3d1..f0038c6efd6c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,12 @@ ## 0.9.2 (Unreleased) +__BACKWARDS INCOMPATIBILITIES:__ + + * client: On startup a client will reattach to running tasks as before but + will not restart exited tasks. Exited tasks will be restarted only after the + client has reestablished communication with servers. System jobs will always + be restarted. [[GH-5669](https://github.com/hashicorp/nomad/pull/5669)] + FEATURES: * core: Add `nomad alloc restart` command to restart allocs and tasks [[GH-5502](https://github.com/hashicorp/nomad/pull/5502)] diff --git a/client/allocrunner/taskrunner/task_runner.go b/client/allocrunner/taskrunner/task_runner.go index 38d48f1fdade..9bf122fe38f7 100644 --- a/client/allocrunner/taskrunner/task_runner.go +++ b/client/allocrunner/taskrunner/task_runner.go @@ -195,8 +195,7 @@ type TaskRunner struct { maxEvents int // serversContactedCh is passed to TaskRunners so they can detect when - // servers have been contacted for the first time in case of a failed - // restore. + // GetClientAllocs has been called in case of a failed restore. serversContactedCh <-chan struct{} // waitOnServers defaults to false but will be set true if a restore