From f7f7746f951a6e3d3e1226481c12c9a3ae77a093 Mon Sep 17 00:00:00 2001 From: Shishir Mahajan Date: Fri, 26 Jun 2020 11:14:53 -0700 Subject: [PATCH] Fix review comments. --- drivers/docker/driver.go | 1 - website/pages/docs/drivers/docker.mdx | 7 ++++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/docker/driver.go b/drivers/docker/driver.go index 52c41e86213c..96d881e813ce 100644 --- a/drivers/docker/driver.go +++ b/drivers/docker/driver.go @@ -826,7 +826,6 @@ func (d *Driver) createContainerConfig(task *drivers.TaskConfig, driverConfig *T // This translates to docker create/run --cpuset-cpus option. // --cpuset-cpus limit the specific CPUs or cores a container can use. if driverConfig.CPUSetCPUs != "" { - logger.Debug(fmt.Sprintf("Setting CPUSetCPUs to %s", driverConfig.CPUSetCPUs)) hostConfig.CPUSetCPUs = driverConfig.CPUSetCPUs } diff --git a/website/pages/docs/drivers/docker.mdx b/website/pages/docs/drivers/docker.mdx index 11cf86c8d226..d1450909c9a0 100644 --- a/website/pages/docs/drivers/docker.mdx +++ b/website/pages/docs/drivers/docker.mdx @@ -78,8 +78,13 @@ The `docker` driver supports the following configuration in the job spec. Only } ``` - `cpuset_cpus` - (Optional) CPUs in which to allow execution (0-3, 0,1). +Limit the specific CPUs or cores a container can use. A comma-separated list +or hyphen-separated range of CPUs a container can use, if you have more than +one CPU. The first CPU is numbered 0. A valid value might be 0-3 (to use the +first, second, third, and fourth CPU) or 1,3 (to use the second and fourth CPU). -Limit the specific CPUs or cores a container can use. A comma-separated list or hyphen-separated range of CPUs a container can use, if you have more than one CPU. The first CPU is numbered 0. A valid value might be 0-3 (to use the first, second, third, and fourth CPU) or 1,3 (to use the second and fourth CPU). +Note: `cpuset_cpus` pins the workload to the CPUs but doesn't give the workload +exclusive access to those CPUs. ```hcl config {