diff --git a/.changelog/10876.txt b/.changelog/10876.txt new file mode 100644 index 000000000000..0b8e16195123 --- /dev/null +++ b/.changelog/10876.txt @@ -0,0 +1,3 @@ +```release-note:bug +client: Fixed bug where meta blocks were not interpolated with task environment +``` diff --git a/client/taskenv/env.go b/client/taskenv/env.go index 3ec32db1759f..b4d5419f7d95 100644 --- a/client/taskenv/env.go +++ b/client/taskenv/env.go @@ -539,9 +539,9 @@ func (b *Builder) buildEnv(allocDir, localDir, secretsDir string, envMap[VaultNamespace] = b.vaultNamespace } - // Copy task meta + // Copy and interpolate task meta for k, v := range b.taskMeta { - envMap[k] = v + envMap[hargs.ReplaceEnv(k, nodeAttrs, envMap)] = hargs.ReplaceEnv(v, nodeAttrs, envMap) } // Interpolate and add environment variables diff --git a/client/taskenv/env_test.go b/client/taskenv/env_test.go index da9edc18e7c5..3584596e9022 100644 --- a/client/taskenv/env_test.go +++ b/client/taskenv/env_test.go @@ -399,6 +399,10 @@ func TestEnvironment_AllValues(t *testing.T) { "b.": "b", ".": "c", } + task.Meta = map[string]string{ + "taskMetaKey-${NOMAD_TASK_NAME}": "taskMetaVal-${node.unique.id}", + "foo": "bar", + } env := NewBuilder(n, a, task, "global").SetDriverNetwork( &drivers.DriverNetwork{PortMap: map[string]int{"https": 443}}, ) @@ -469,6 +473,7 @@ func TestEnvironment_AllValues(t *testing.T) { "NOMAD_META_elb_check_type": "http", "NOMAD_META_foo": "bar", "NOMAD_META_owner": "armon", + "NOMAD_META_taskMetaKey_web": "taskMetaVal-" + n.ID, "NOMAD_JOB_ID": a.Job.ID, "NOMAD_JOB_NAME": "my-job", "NOMAD_JOB_PARENT_ID": a.Job.ParentID, @@ -513,7 +518,8 @@ func TestEnvironment_AllValues(t *testing.T) { out := "" diag = gohcl.DecodeExpression(expr, evalCtx, &out) require.Empty(t, diag) - require.Equal(t, out, expectedVal) + require.Equal(t, expectedVal, out, + fmt.Sprintf("expected %q got %q", expectedVal, out)) }) } }