Service Check stanza should support HTTP body

[manveru]

Nomad version

v1.0.4

Operating system and Environment details

NixOS

Issue

The job -> group -> service -> check stanza doesn't support setting a body for http checks.
This should be supported, since Consul has the corresponding option: https://www.consul.io/api/agent/check#body

Reproduction steps

❯ nomad job run -output ./hi.hcl         
Error getting job struct: Error parsing job file from ./hi.hcl:
hi.hcl:6,9-13: Unsupported argument; An argument named "body" is not expected here.

Job file (if appropriate)

job "hi" {
  group "hi" {
    service {
      check {
        type = "http"
        body = "hello"
      }
    }
  }
}

[shoenig]

Thanks for the issue, @manveru! This seems reasonable. It shouldn't be difficult to add as it's mostly plumbing from jobspec to the Consul service registration API, and there's plenty of similar fields to look at.

[nick96]

Hey! I've had a go at this in #10186. I'm a bit stuck on getting the body field to update when the job is updated. I'm guessing it's something in nomad/structs/diff.go but I can't figure out exactly what.

[tgross]

Closed by #10186 and will ship in Nomad 1.1.0.

[github-actions]

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.