-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client panic when submitting a job with exposed service check and no sidecar_service stanza #10115
Comments
The panic here affect the server RPC handler, affecting the goroutine processing the request. The server continues to operate undisturbed without a full process crash. The API consumers do get indecipherable EOF error message though. The bug sadly dates back to 0.10.0! The stack traces are a bit different. Nomad 0.11.0 fails with the same stack trace as 1.0.4 and included above in the original report. Server 0.11.0
Server 0.10.0
|
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
Nomad version
Nomad v1.0.4 (9294f35)
Operating system and Environment details
vagrant-nomad with v1.0.4
Issue
When submitting a job with a check that has
expose = true
, but nosidecar_service
stanza, the client panics.Reproduction steps
Submit an otherwise complete
countdash.nomad
, without thesidecar_service
stanza on the count-api service.Expected Result
A validation error of some kind is returned, because the service's check has
expose = true
, and that's invalid without a minimalconnect
stanza, meaning one that also has an emptysidecar_service
stanza.Actual Result
The CLI returns an EOF:
If we submit an equivalent job via the HTTP API, we confirm the empty response:
Job file (if appropriate)
Nomad Server logs (if appropriate)
N/A
Nomad Client logs (if appropriate)
The text was updated successfully, but these errors were encountered: