Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

networking: Ensure CNI iptables rules are appended to chain and not forced to be first #10181

Merged
merged 1 commit into from
Apr 15, 2021
Merged

networking: Ensure CNI iptables rules are appended to chain and not forced to be first #10181

merged 1 commit into from
Apr 15, 2021

Conversation

microadam
Copy link
Contributor

Fixes #10180

I wasn't sure if there was a reason for the forcing first, but if not, this PR appends the rule, rather than forcing first

@hashicorp-cla
Copy link

hashicorp-cla commented Mar 13, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@vercel vercel bot temporarily deployed to Preview – nomad March 13, 2021 19:32 Inactive
@tgross tgross self-requested a review March 24, 2021 19:59
@tgross tgross added this to Needs Triage in Nomad - Community Issues Triage via automation Mar 24, 2021
@tgross tgross moved this from Needs Triage to In Progress in Nomad - Community Issues Triage Mar 24, 2021
tgross
tgross approved these changes Apr 15, 2021
View reviewed changes
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I've verified this seems to do the right thing when clients get restarted. I'll push a separate PR with the changelog and an upgrade guide note as well.

@tgross tgross merged commit da27daf into hashicorp:main Apr 15, 2021
Nomad - Community Issues Triage automation moved this from In Progress to Done Apr 15, 2021
@tgross tgross mentioned this pull request Apr 15, 2021
Merged
@tgross tgross added this to the 1.1.0 milestone Apr 15, 2021
@tgross tgross mentioned this pull request Apr 15, 2021
Closed
@microadam
Copy link
Contributor Author

Awesome! thank you! :)

picatz added a commit to picatz/terraform-google-nomad that referenced this pull request May 31, 2021
@picatz
Block access to the metadata endpoint with NOMAD-AMDIN
0a25c76 
Thanks to hashicorp/nomad#10181
@optiz0r optiz0r mentioned this pull request Nov 19, 2021
Closed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tgross tgross tgross approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

Unable to add firewall rules to IP Tables: Nomad enforces first rule
3 participants
@microadam @hashicorp-cla @tgross