-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added host network interpolation #10196
added host network interpolation #10196
Conversation
Hi @AndrewChubatiuk sorry about the delay here... I want to make sure that the root problem of #10106 is better understood before we review this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AndrewChubatiuk! I'm not sure I understand what this approach to interpolation is doing. But generally speaking we do any interpolation that's going to happen at either job submission time or on the client (sometimes both). It might help if there were tests?
@tgross |
@AndrewChubatiuk maybe the code is fine where it is, but there's no tests and no "interpolation" going on here, so I can't even use the commit message to figure out what you're doing. If you can provide more context, I can review it. |
@tgross |
@tgross |
LGTM. I've rebased this on |
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Fixes #10195