Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSI: report specific capabilities w/ plugin status output #10221

Closed
tgross opened this issue Mar 24, 2021 · 2 comments · Fixed by #12116
Closed

CSI: report specific capabilities w/ plugin status output #10221

tgross opened this issue Mar 24, 2021 · 2 comments · Fixed by #12116

Comments

@tgross
Copy link
Member

tgross commented Mar 24, 2021

Right now the only good way to get the specific capabilities that a CSI plugin supports is via the Container Storage Client (csi):

$ sudo csc --endpoint /var/nomad/client/csi/controller/cephrbd/csi.sock controller get-capabilities
&{type:CREATE_DELETE_VOLUME }
&{type:CREATE_DELETE_SNAPSHOT }
&{type:CLONE_VOLUME }
&{type:EXPAND_VOLUME }

The nomad plugin status -verbose flag just expands the UUIDs:

$ nomad plugin status -verbose cephrbd
ID                   = cephrbd
Provider             = rbd.csi.ceph.com
Version              = canary
Controllers Healthy  = 1
Controllers Expected = 1
Nodes Healthy        = 1
Nodes Expected       = 1

Allocations
ID                                    Eval ID                               Node ID                               Node Name   Task Group  Version  Desired  Status   Created                    Modified
8b2eb95a-32e2-c7d4-f939-b968137e6c81  1fc9d37b-ed78-9093-5ef7-2836e3e39051  23542ed8-4b49-35a5-f74d-892d980cecf0  standalone  cephrbd     0        run      running  2021-03-24T10:13:54-04:00  2021-03-24T10:14:05-04:00
2ad097b8-9ff0-ef9b-f42a-f6173e89f8cd  67331428-fcf5-0912-fdc1-7904608a7403  23542ed8-4b49-35a5-f74d-892d980cecf0  standalone  cephrbd     0        run      running  2021-03-24T10:13:55-04:00  2021-03-24T10:14:01-04:00

We could add a list of supported capabilities to the API and report them here.

@tgross
Copy link
Member Author

tgross commented Feb 3, 2022

Copied context from #11859:

While working on debugging #10927 with some new-to-me CSI plugins, I found that being able to query the plugin capabilities as part of the output of nomad plugin status :plugin_id would be useful (perhaps only with the -verbose flag). The information is available in the state store, so it's just a matter of plumbing through all the RPC response, the HTTP API, and then the CLI.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant