Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory metrics: only publish measured metrics #10376

Merged
merged 1 commit into from
Apr 13, 2021
Merged

memory metrics: only publish measured metrics #10376

merged 1 commit into from
Apr 13, 2021

Conversation

notnoop
Copy link
Contributor

@notnoop notnoop commented Apr 13, 2021

This partially addresses #9073 - where non-measured metrics don't get reported as zero.

I haven't updated the CPU reporting mechanism. It's tricker, as the measured metrics doesn't directly translate to set fields.

@notnoop notnoop requested review from shoenig and tgross April 13, 2021 15:06
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@notnoop notnoop merged commit fa95eb6 into main Apr 13, 2021
@notnoop notnoop deleted the b-stats-metrics branch April 13, 2021 15:39
schmichael pushed a commit that referenced this pull request May 14, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants