driver/docker: ignore error if container exists before cgroup can be written #10416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notnoop
reviewed
Apr 21, 2021
| return cgroups.WriteCgroupProc(path, pid) | ||
| // Sometimes the container exists before we can write the | ||
| // cgroup resulting in an error which can be ignored. | ||
| if err := cgroups.WriteCgroupProc(path, pid); err != nil { |
There was a problem hiding this comment.
I don't recall the semantics of children processes and WriteCgroupProc. Is there a risk that we may miss some children processes here? Like if PID 1 is a entrypoint script and launches the main process without using exec, the main process may not be included in the cpusets?
notnoop
approved these changes
Jun 9, 2021
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an edge case in the reserved cores feature where switching the cpuset of a docker container occurs after the container has exited.