Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace api.Job -> structs.Job conversion #10471

Open
tgross opened this issue Apr 29, 2021 · 2 comments
Open

replace api.Job -> structs.Job conversion #10471

tgross opened this issue Apr 29, 2021 · 2 comments
Labels
theme/api HTTP API and SDK issues theme/cleanup

Comments

@tgross
Copy link
Member

tgross commented Apr 29, 2021

In command/agent/job_endpoint.go we have a manual conversion between api.Job and structs.Job. This has proven to be fiddly and error-prone. #10202 introduced some encoding improvements that make it possible to remove most of this code so that we can implement a few hooks for fields we want to redact and that's it.
@tgross tgross added theme/api HTTP API and SDK issues theme/cleanup labels Apr 29, 2021
@tgross tgross mentioned this issue Apr 29, 2021
Open
@tgross
Copy link
Member Author

tgross commented Jun 22, 2021

cc @DerekStrickland as a heads up

@tgross tgross mentioned this issue Jul 6, 2021
Merged
@tgross
Copy link
Member Author

tgross commented Jul 6, 2021

See #10834 and #10855 for another case where this has gone wrong.

@DerekStrickland DerekStrickland removed their assignment Nov 9, 2021
@tgross tgross self-assigned this Apr 15, 2022
@tgross tgross mentioned this issue Apr 15, 2022
Merged
@tgross tgross mentioned this issue Aug 1, 2022
Merged
14 tasks
@tgross tgross removed their assignment Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
theme/api HTTP API and SDK issues theme/cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DerekStrickland @tgross