-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nomad snapshot create does use persisted secrets #10639
Comments
Hi @ggriffiths. Thanks for opening this issue! Just FYI that secrets are intentionally redacted from any query request, so that |
Of course! That makes sense. If the fix is straightforward enough, I'd be happy to send a PR! Looks like from a first glance, this line: Line 1128 in 97af3e9
might need to be |
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
Nomad version
Operating system and Environment details
CentOS-7
Issue
Nomad volume create does not seem to persist any values from the
secrets
block. The secrets are passed to the CSI Driver, as I'm able to useauth-token
in the Portworx CSI Driver create call, however when creating a snapshot, I'm not seeing these secrets propagated to the snapshot create call. I'm not sure if this is by design or not. If this is by design, is there a way to have secrets passed tonomad volume snapshot create/delete
?The
nomad volume status --json
command shows null secrets:Reproduction steps
Expected Result
Secrets should be persisted during volume create
Actual Result
Secrets are not persisted during volume create
Job file (if appropriate)
n/a
Nomad Server logs (if appropriate)
n/a
Nomad Client logs (if appropriate)
n/a
The text was updated successfully, but these errors were encountered: