cli: improve wildcard namespace prefix matches #10648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a wildcard namespace is used for `nomad job` commands that support prefix matching, avoid asking the user for input if a prefix is an unambiguous exact match so that the behavior is similar to the commands using a specific or unset namespace.
tgross
force-pushed
the
b_job_status_prefix_match
branch
from
e03586b
to
dd24cf9
Compare
shoenig
approved these changes
May 24, 2021
command/job_deployments.go
Outdated
| c.Ui.Error(fmt.Sprintf("Prefix matched multiple jobs\n\n%s", createStatusListOutput(jobs, c.allNamespaces()))) | ||
| return 1 | ||
| if len(jobs) > 1 { | ||
| if strings.TrimSpace(jobID) != jobs[0].ID { |
There was a problem hiding this comment.
nit: couldn't we move the TrimSpace up above, i.e. jobID := strings.TrimSpace(args[0])
There was a problem hiding this comment.
Alternately, we could remove it and punish anyone who intentionally does nomad job status " example " 😀
Will fix!
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10625
When a wildcard namespace is used for
nomad jobcommands that support prefixmatching, avoid asking the user for input if a prefix is an unambiguous exact
match so that the behavior is similar to the commands using a specific or
unset namespace.