ui: Fix fuzzy search namespace-handling #10666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is “@ namespace” sensible? 🧐
Ember Asset Size actionAs of 00df085 Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
|
@JBhagat841 I'm assigning this to you just so that we don't lose track of open PRs from Buck, but there's no special rush on it other than that we should try to ship it in the 1.1.x cycle. |
Namespaces are set-up in Nomad to be an object that has an id property. However, namespaces actually don't have that shape. Our search was expecting a namespace object, but we actually don't have a namespace assigned to jobs in our config and namespace is set to null. Normally, these namespaces would be set to default, but that would require us to refactor our Mirage config if we wanted to assert that namespaces are 'default' and not null. So this is a bandaid solution.
ChaiWithJai
force-pushed
the
b-ui/search-namespaces
branch
from
e354f68
to
2649d19
Compare
lgfa29
suggested changes
Aug 5, 2021
lgfa29
approved these changes
Aug 9, 2021
ChaiWithJai
force-pushed
the
b-ui/search-namespaces
branch
from
88c29dd
to
2c30c33
Compare
ChaiWithJai
force-pushed
the
b-ui/search-namespaces
branch
from
2c30c33
to
00df085
Compare
notnoop
pushed a commit
that referenced
this pull request
Aug 26, 2021
ui: Fix fuzzy search namespace-handling
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial UI for fuzzy search failed to include the flag to query across all namespaces. This also has a suggested implementation for showing namespaces in job and allocation label like
job @ namespace, but this is perhaps not an established pattern in the UI, and maybe other search results should have namespaces too, maybe it should be lighter grey…? Things to consider 🤔