Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GC Docker containers and images after the container exits #1071

Merged
merged 4 commits into from
Apr 14, 2016

Conversation

diptanu
Copy link
Contributor

@diptanu diptanu commented Apr 12, 2016

Fixes #973

@diptanu diptanu changed the title B docker fix gc GC Docker containers and images after the container exits Apr 12, 2016
@sheerun
Copy link
Contributor

sheerun commented Apr 12, 2016

How does it relate to following? Are logs still kept?

The idea behind keeping the allocations after they have completed for some time is to allow users to inspect the allocation once they have finished in case they want to debug something.

@dadgar
Copy link
Contributor

dadgar commented Apr 12, 2016

@sheerun They are unrelated. This is about cleaning up the container which is managed by docker while logs are managed by us.

@diptanu
Copy link
Contributor Author

diptanu commented Apr 13, 2016

@sheerun Yes, like @dadgar said logs would still be retained as they live in the allocation directory and we don't ask Docker to remove the volumes when we remove the container.


// Ensure that the container isn't present
info, err := client.InspectContainer(handle.(*DockerHandle).containerID)
fmt.Printf("INFO %#v \n", info)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove debug print

@dadgar dadgar merged commit 3703ff4 into master Apr 14, 2016
@dadgar dadgar deleted the b-docker-fix-gc branch April 14, 2016 17:26
@github-actions
Copy link

github-actions bot commented Feb 6, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants