Add remaining pprof profiles to nomad operator debug #10748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoenig
approved these changes
Jun 21, 2021
davemay99
force-pushed
the
f-debug-profiles
branch
from
27730d4
to
5be0076
Compare
|
Rebased with CHANGELOG.md updates, will merge after tests complete. |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds to the remaining pprof profiles to
nomad operator debug. It also adds 2 helper functionsWaitForResultUntilandWaitForFilesUntilwhich reduce the flakiness of the associated test.In the future the
blockandmutexprofiles can be enabled using theruntime.SetBlockProfileRateandruntime.SetMutexProfileFractionfunctions, respectively.