Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: fixed system commands so they correctly use passed flags. #10822

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

jrasell
Copy link
Member

@jrasell jrasell commented Jun 28, 2021

closes #10820

Tests have been modified to ensure the flag usage is tested.

@jrasell jrasell added type/bug theme/cli stage/accepted Confirmed, and intend to work on. No timeline committment though. labels Jun 28, 2021
@jrasell jrasell self-assigned this Jun 28, 2021
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrasell jrasell merged commit d1a9302 into main Jun 29, 2021
@jrasell jrasell deleted the b-gh-10820 branch June 29, 2021 08:11
jrasell added a commit that referenced this pull request Jun 29, 2021
jrasell added a commit that referenced this pull request Jun 30, 2021
@notnoop notnoop mentioned this pull request Jul 28, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/cli type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nomad system gc doesn't take into account command line variables, only environment variables
2 participants