-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metrics don't emit max_memory #10838
Comments
@tgross is this something that a new contributor can pick up? would like to work on this. |
Hi @danishprakash! It should be reasonably approachable. We emit the metrics for allocated memory in |
@tgross thanks for the response. I ran into some issues while running |
@danishprakash just wanted to follow-up on this one... the branch you have up looks reasonable to me. If you're interested in opening a PR we could try to get that merged in. I realize it's been a while though, so if you don't have time I'd can pick it up. |
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
We emit the allocated memory for tasks but not the max_memory for oversubscription, which means you can't use the metrics endpoint to track how close you are to OOM when oversubscribed.
cc @angrycub
The text was updated successfully, but these errors were encountered: