scheduler: datacenter updates should be destructive #10864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates to the datacenter field should be destructive for any allocation that is on a node no longer in the list of datacenters, but inplace for any allocation on a node that is still in the list. Add a check for this change to the system and generic schedulers after we've checked the task definition for updates and obtained the node for each current allocation.
tgross
force-pushed
the
b-10746-plan-datacenter
branch
from
7461a56
to
00fb80f
Compare
tgross
commented
Jul 7, 2021
Comment on lines
+704
to
+707
| // The alloc is on a node that's now in an ineligible DC | ||
| if !helper.SliceStringContains(job.Datacenters, node.Datacenter) { | ||
| continue | ||
| } |
There was a problem hiding this comment.
As I noted in #10746 (comment) I'm not wild about the placement of this check, because it means we can't really test the behavior except in the whole-scheduler tests as I've done in TestServiceSched_JobModify_Datacenters
Merged
notnoop
pushed a commit
that referenced
this pull request
Jul 28, 2021
scheduler: datacenter updates should be destructive
notnoop
pushed a commit
that referenced
this pull request
Jul 29, 2021
scheduler: datacenter updates should be destructive
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10746
Updates to the datacenter field should be destructive for any allocation that
is on a node no longer in the list of datacenters, but inplace for any
allocation on a node that is still in the list. Add a check for this change to
the system and generic schedulers after we've checked the task definition for
updates and obtained the node for each current allocation.