client: interpolate meta blocks with task environment #10876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
force-pushed
the
b-meta-interpolation
branch
from
aa10d20
to
47e8f0b
Compare
shoenig
reviewed
Jul 8, 2021
There was a problem hiding this comment.
In the services version of this, we interpolate both the key and the value of a meta block. Do we want to do the same here?
https://github.com/hashicorp/nomad/blob/main/client/taskenv/services.go#L165
goes to
nomad/client/taskenv/services.go
Line 70 in 72f431f
Adds missing interpolation step to the `meta` blocks when building the task environment. Also fixes incorrect parameter order in the test assertion and adds diagnostics to the test.
tgross
force-pushed
the
b-meta-interpolation
branch
from
47e8f0b
to
1cc1bda
Compare
Merged
notnoop
pushed a commit
that referenced
this pull request
Jul 28, 2021
Adds missing interpolation step to the `meta` blocks when building the task environment. Also fixes incorrect parameter order in the test assertion and adds diagnostics to the test.
notnoop
pushed a commit
that referenced
this pull request
Jul 29, 2021
Adds missing interpolation step to the `meta` blocks when building the task environment. Also fixes incorrect parameter order in the test assertion and adds diagnostics to the test.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6506 so our
metadocs are correct.Adds missing interpolation step to the
metablocks when building the taskenvironment. Also fixes incorrect parameter order in the test assertion and
adds diagnostics to the test.