Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nomad alloc signal help message #10917

Merged
merged 3 commits into from
Jul 21, 2021
Merged

fix nomad alloc signal help message #10917

merged 3 commits into from
Jul 21, 2021

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Jul 20, 2021

The nomad alloc signal CLI command takes the signal input as a flag.

@vercel vercel bot temporarily deployed to Preview – nomad July 20, 2021 22:20 Inactive
jrasell
jrasell approved these changes Jul 21, 2021
View reviewed changes
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion inline alongside the suggestion of adding the default signal used in the help message for the -s flag. I had to look at the code to find this out. These are not blockers though. LGTM and nice catch!

command/alloc_signal.go Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – nomad July 21, 2021 14:40 Inactive
@lgfa29
Copy link
Contributor Author

lgfa29 commented Jul 21, 2021

Minor suggestion inline alongside the suggestion of adding the default signal used in the help message for the -s flag. I had to look at the code to find this out. These are not blockers though. LGTM and nice catch!

Good call, added. Thanks!

@lgfa29 lgfa29 merged commit d621759 into main Jul 21, 2021
@lgfa29 lgfa29 deleted the fix-alloc-signal-help-msg branch July 21, 2021 15:02
@notnoop notnoop mentioned this pull request Jul 28, 2021
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jrasell jrasell jrasell approved these changes

@isabeldepapel isabeldepapel Awaiting requested review from isabeldepapel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lgfa29 @jrasell