cli: Use glint to determine if os.Stdout is tty #10926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 22, 2021 12:54
isabeldepapel
approved these changes
Jul 23, 2021
command/deployment_status.go
Outdated
|
|
||
| d.RenderFrame() |
There was a problem hiding this comment.
Silly question, but why is RenderFrame() getting called here--does it have to do with calculating the terminal size?
There was a problem hiding this comment.
Excellent question actually. It doesn't belong here! I added it for debugging to force the rendering in main thread rather than in a goroutine!
Merged
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use glint to determine if os.Stdout is a terminal.
glint Terminal renderer expects os.Stdout not only to be a terminal, but also to have non-zero size. It's unclear how this condition arises, but this additional check causes Nomad to render deployments progress through glint when glint cannot support it.
By using golint to perform the check, we eliminate the risk of mis-judgement.
I opened mitchellh/go-glint#4 to fix the panic upstream: mitchellh/go-glint#4 . The upstream fix isn't sufficient for us, as it would just skip rendering deployments in this condition, instead of going the non-terminal rendering path in Nomad.
Fixes #10923