fix: load token in docker auth config #10929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jrasell
approved these changes
Aug 4, 2021
jrasell
added
backport/1.1
stage/accepted
jrasell
added a commit
that referenced
this pull request
Aug 5, 2021
jrasell
added a commit
that referenced
this pull request
Aug 5, 2021
changelog: add entry for #10929
notnoop
pushed a commit
that referenced
this pull request
Aug 26, 2021
fix: load token in docker auth config
notnoop
pushed a commit
that referenced
this pull request
Aug 26, 2021
fix: load token in docker auth config
notnoop
pushed a commit
that referenced
this pull request
Aug 26, 2021
changelog: add entry for #10929
notnoop
pushed a commit
that referenced
this pull request
Aug 26, 2021
changelog: add entry for #10929
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
When evaluating Nomad on Azure I came across an authentication issue with our Azure Container Registry.
I looked at #10722 but I was not able to find a sustainable solution (other Azure authentication means could have worked, but I had not the opportunity to test)
After digging into the code, I found out that the IdentityToken from the docker.json auth config is simply not used and therefore not passed to docker, resulting in the authentication issue; I also added the RegistryToken, since it is missing as well.
I'm not sure AWS auth works the same, but it may explain why some solutions work but other not.
This is my first golang PR so please let me know if there is anything I'm not handling or could improve.
Thanks for your amazing work!