ui: fix job dispatch page when job doesn't have any meta fields #10934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ember Asset Size actionAs of 26d7eb6 Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
ChaiWithJai
reviewed
Aug 3, 2021
| @@ -47,7 +47,7 @@ export default class JobDispatch extends Component { | |||
| super(...arguments); | |||
|
|
|||
| // Helper for mapping the params into a useable form. | |||
| const mapper = (values = [], required) => | |||
| const mapper = (values, required) => | |||
There was a problem hiding this comment.
Why are we removing the default parameter on this function?
ChaiWithJai
approved these changes
Aug 3, 2021
lgfa29
added a commit
that referenced
this pull request
Aug 4, 2021
lgfa29
added a commit
that referenced
this pull request
Aug 4, 2021
notnoop
pushed a commit
that referenced
this pull request
Aug 26, 2021
notnoop
pushed a commit
that referenced
this pull request
Aug 26, 2021
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a job doesn't have any meta field declared, the API returns
null. The previous logic would not cover this case.