Nomad plan confused by multiple services with the same name.

[apollo13]

Nomad version

Nomad v1.1.2 (60638a0)

Operating system and Environment details

Not relevant

Issue

The output from plan is simply wrong, it conflates multiple services with the same name (please note that this is fine from a consul perspective and nomad itself does the "same" when registering multiple ports to the "nomad" service).

Reproduction steps

Deploy:

job "whoami-test" {
  datacenters = ["dc1"]

  group "whoami" {
    network {
      mode = "bridge"
      port "expose" {}
    }

    service {
      name = "whoami"
      port = 80
      tags = [
        "traefik.enable=true",
        "traefik.consulcatalog.connect=true",
        "traefik.http.routers.whoami.rule=Host(`whoami.example.com`)"
      ]

      connect {
        sidecar_service {}
      }
    }

    #service {
    #  name = "whoami"
    #  port = "expose"
    #  tags = ["test"]
    #}

    task "whoami" {
      driver = "docker"
      config {
        image = "containous/whoami"
      }
    }
  }
}

Uncommented the commented service and plan:

+/- Job: "whoami-test"
+/- Task Group: "whoami" (1 in-place update)
  +/- Service {
        AddressMode:       "auto"
        EnableTagOverride: "false"
        Name:              "whoami"
        Namespace:         "default"
        OnUpdate:          "require_healthy"
    +/- PortLabel:         "80" => "expose"
        TaskName:          ""
    +/- Tags {
      + Tags: "test"
      - Tags: "traefik.consulcatalog.connect=true"
      - Tags: "traefik.enable=true"
      - Tags: "traefik.http.routers.whoami.rule=Host(`whoami.example.com`)"
        }
    -   ConsulConnect {
        - Native: "false"
        - SidecarService {
          - DisableDefaultTCPCheck: "false"
            Port:                   ""
          }
        }
      }
      Task: "connect-proxy-whoami"
      Task: "whoami"

Scheduler dry-run:
- All tasks successfully allocated.

Job Modify Index: 919746
To submit the job with version verification run:

Actually deploy the planned version and observe the result:

curl https://consul.infra.bap.co.at/v1/catalog/service/whoami | jq

(or via the webui) You will see that nomad/consul properly created two instances for the service:

Expected Result

Nomad plan should properly differentiate between services with the same name

Actual Result

The last service in the nomad file seems to "win"

[apollo13]

I have started working on a draft PR, not really sure what the best way to separate the services would be -- ideas welcome (currently I do name+portlabel)

[apollo13]

I guess the main question about my PR is whether we can accept that a change in port label means "deletion & creation" of the service as opposed to a "change".

[github-actions]

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.